Sprite is not showing up right

[blue_bear_94]

I was making a movement example and everything works except that the sprite is showing up as a line instead of a box. If anyone could help me, thanks in advance!

Code: Select All | Copy To Clipboard

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95

#include    "ti83plus.inc" #define     progStart   $9D95 .org        progStart-2 .db         $BB,$6D x .equ AppBackUpScreen y .equ AppBackUpScreen+1 push bc     push de     ld hl,x     ld (hl),0     ld hl,y     ld (hl),0 MainLoop:     call EraseSpr     ld a,%11111110     out ($01),a     in a,($01)     ld b,a     bit 0,b     call z,Down     bit 1,b     call z,Left     bit 2,b     call z,Right     bit 3,b     call z,Up     call DrawSpr     ld a,%11111101     out ($01),a     in a,($01)     cp %10111111     jr nz,MainLoop     pop de     pop bc     ret Down:     ld hl,y     ld a,(hl)     cp 55     ret z     inc (hl)     ret Up: ld hl,y     ld a,(hl)     cp 0     ret z dec (hl)     ret Left: ld hl,x     ld a,(hl)     cp 0     ret z dec (hl)     ret Right: ld hl,x     ld a,(hl)     cp 87     ret z inc (hl)     ret BoxPic: .db 1,8 .db %11111111 .db %10000001 .db %10000001 .db %10000001 .db %10000001 .db %11111111 BoxErase: .db 1,8 .db 0 .db 0 .db 0 .db 0 .db 0 .db 0 DrawSpr: ld hl,y     ld d,(hl)     ld hl,x     ld e,(hl)     ld hl,BoxPic     bcall(_DisplayImage)     ret EraseSpr:     ld hl,y     ld d,(hl)     ld hl,x     ld e,(hl)     ld hl,BoxErase     bcall(_DisplayImage)     ret

[thepenguin77]

I've never seen the bcall _displayImage before. It looks really useful for you, just be warned that since it's a drawing routine by TI, it is going to be super super slow.

In any case, I don't have that much time to look at it right now, but I think you got the input for the bcall wrong. The bcall says your data structure needs to be height, width, data. So, for each of your sprites, the height is set to 1. Set that back to 8 and I think you'll have a box.

[chickendude]

Also, why do you push bc/de at the start of the program? I've never heard of the _displayImage BCALL before either, i'd recommend checking out ion's putsprite routine (copying/pasting the code into your program somewhere):

ionPutSprite:
   Draw a sprite to the graph buffer (XOR).
   Input:   b=sprite height
      a=x coordinate
      l=y coordinate
      ix->sprite
   Output:   Sprite is XORed to the graph buffer.
      ix->next sprite
   Destroys: af bc de hl ix

Code: Select All | Copy To Clipboard

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41

putSprite:     ld    e,l     ld    h,$00     ld    d,h     add    hl,de     add    hl,de     add    hl,hl     add    hl,hl               ;Find the Y displacement offset     ld    e,a     and    $07               ;Find the bit number     ld    c,a     srl    e     srl    e     srl    e     add    hl,de             ;Find the X displacement offset     ld    de,gbuf     add    hl,de putSpriteLoop1: sl1:    ld    d,(ix)             ;loads image byte into D     ld    e,$00     ld    a,c     or    a     jr    z,putSpriteSkip1 putSpriteLoop2:     srl    d                  ;rotate to give out smooth moving     rr    e     dec    a     jr    nz,putSpriteLoop2 putSpriteSkip1:     ld    a,(hl)     xor    d     ld    (hl),a     inc    hl     ld    a,(hl)     xor    e     ld    (hl),a              ;copy to buffer using XOR logic     ld    de,$0B     add    hl,de     inc    ix                   ;Set for next byte of image     djnz    putSpriteLoop1     ret

If your program is just drawing one line, like thepenguin said it's probably from bad parameters that you're passing to the BCALL and drawing only the first row of the sprite.