Sprites and Maps in C 68k

[Lionel Debroux]

Don't write to LCD_MEM in grayscale mode

[Kiligolo]

It's ranman's code: http://www.omnimaga.org/index.php?topic=6438.msg116833#msg116833 :p

[Lionel Debroux]

Ranman's code was meant for B/W, but grayscale is another story

See http://debrouxl.github.com/gcc4ti/gray.html#GrayGetPlane :

GrayGetPlane returns a pointer to the grayscale plane plane. Valid values for plane are LIGHT_PLANE and DARK_PLANE. To draw in black, draw in both planes.

Note: Do not assume that any plane is on 0x4C00 when in grayscale mode, due to hardware version 2 support. Also do not assume that the 2 grayscale planes are consecutive, this is not the case on hardware version 1.

Some software grayscale implementations have two consecutive grayscale planes, but the one in TIGCC and GCC4TI doesn't.

[Kiligolo]

Thanks it's works!

But now i have a problem when i stop the program. The light plane is displayed in black and there is white rectangles which appear and disapear on the screen, i can't do anything. (Fortunatly i am on tiEmu)...

[Lionel Debroux]

When exiting by ESC, you immediately "return 0;" instead of falling out of the outer while(), which calls GrayOff()

If if still doesn't work properly after that, make sure you aren't drawing past the beginning or the end of the screen, and try using ClipSprite8 instead of Sprite8

And if your map is only read from, but not written to, you really should declare it "static const", so that it ends up as a constant in your program's code, instead of being constructed onto the stack: it will be both smaller and faster.

[Xeda112358]

sorry to interrupt again .___.
I tried modifying the code to suite my purposes and I keep getting these errors and I don't know why

'MAP_Y' undeclared (first use in this function).
'MAP_X' undeclared (first use in this function).
Unused variable 'map1'.


EDIT: also, KERNELBASE.dll seems to have a lot of issues with me, so ever time I get an error, it freezes and uses up tons of system resources and I have to press F10 a bazillion times and click okay on a bunch of popup error messages

[Torio]

You have an error because MAP_X and MAP_Y are not defined in the code you copied.
You have to put before the code :

Code: Select All | Copy To Clipboard

1 2	#define MAP_X 20 #define MAP_Y 12

I guess it should be 20 and 12 according to the table map1, but I'm not sure.

[Kiligolo]

Lionel > Yes
Xeda >

Code: Select All | Copy To Clipboard

1 2 3 4

#include <tigcclib.h> #define MAP_X 20 #define MAP_Y 12

It's the map size.
For map1 error:

Code: Select All | Copy To Clipboard

1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66

unsigned char game_sprites[2][8] = //array of sprites { //Grass    0b00000000,    0b00101000,    0b00010000,    0b00000000,    0b00000101,    0b00000010,    0b01010000,    0b00100000, }, { //tree    0b00000000,    0b00000000,    0b00111110,    0b01111111,    0b01111111,    0b01111111,    0b00111110,    0b00001000, } unsigned char map[8][8] = {    {1,1,1,1,1,1,1,1},    {1,0,0,0,0,0,0,1},    {1,0,0,0,0,0,0,1},    {1,0,0,0,0,0,0,1},    {1,0,0,0,0,0,0,1},    {1,0,0,0,0,0,0,1},    {1,0,0,0,0,0,0,1},    {1,1,1,1,1,1,1,1}, }; //0 = Grass and 1 = Tree //Drawing: int tilemap_x, tilemap_y; int lcd_x, lcd_y; unsigned char* pSprite; unsigned char sprite_index; // initialize the lcd Y value since we starting the first row lcd_y = 0; for (tilemap_y = 0; tilemap_y < 8; tilemap_y++) {   // initialize the lcd X value since we are starting a new collumn   lcd_x = 0;   for (tilemap_x = 0; tilemap_x < 8; tilemap_x++)   {     // first, get the sprite index from the tilemap     sprite_index = game_tilemap[tilemap_y][tilemap_x];     // second, get the pointer (address) to the sprite     pSprite = &game_sprites[sprite_index][0];     // draw the sprite to the screen     Sprite8 (lcd_x, lcd_y, 8, pSprite, LCD_MEM, SPRT_RPLC); // --> TIGCC lib     // increment the lcd X position in preparation for next sprite     lcd_x = lcd_x + 8;   }   // increment the lcd Y position in preparation for next row of sprites   lcd_y = lcd_y + 8; }

[Kiligolo]

Thanks lionel im very tired today i go to sleep! :p

[Xeda112358]

Thank you much! I wasn't sure how to define MAP_X and MAP_Y, but now I know! Thanks!

[Kiligolo]

Hi! I have a big problem with dynamic allocation...
Here is the code:

Code: Select All | Copy To Clipboard

1 2 3 4 5 6

int i, j; unsigned char ** map = malloc(MAP_Y * sizeof(unsigned char)); for (i = 0; i < MAP_Y; i++) { map[i] = malloc(MAP_X * sizeof(unsigned char)); }

and at the end :

Code: Select All | Copy To Clipboard

1 2 3 4 5

for (i = 0; i < MAP_Y ; i++) { free(map[i]); } free(map);

When i start the program, the Ti89 display BUSY icon and freeze but when i add ngetchx(); in this part of code:

Code: Select All | Copy To Clipboard

1 2 3 4 5 6 7 8

int i, j; unsigned char ** map = malloc(MAP_Y * sizeof(unsigned char)); for (i = 0; i < MAP_Y; i++) {                 printf("%d",i);                 ngetchx(); //Here map[i] = malloc(MAP_X * sizeof(unsigned char)); }

The 89 don't freeze and the program start but when i stop the program and i go to Var-Link menu, my asm program is now and expression (64000bytes).
I'm lost

[Lionel Debroux]

I'm not sure why you need dynamic allocation here ?
(and by they way, two-dimensional arrays suck for efficiency)

The symptoms (BUSY on exit, program size changed, program behaviour changing by adding unrelated lines) point out to severe memory corruption, by overflowing buffers on the heap. Check your code

[Kiligolo]

Ok i'm going to try without it.

[Torio]

I'm not sure but I think you have a memory corruption because when you call malloc for the first time, you will allocate unsigned char for *map.
But in the for loop, the array will contain not an unsigned char, but a pointer so it is a long int.
So the adress to which *map points to will be wrong.
That will cause a corruption when freeing the array.

What you should do is :

Code: Select All | Copy To Clipboard

1	unsigned char *map = malloc(MAP_X * MAP_Y * sizeof(unsigned char));

[Kiligolo]

Thanks for your help! My program is okay now :p