Join/part/quit messages

[Deep Toaster]

aren't showing up anymore

EDIT: I lied. Join/part messages do show up, but not quits.

[DJ Omnimaga]

Yeah I noticed

[Darl181]

Another bug...all joins show as [6:00:00 PM] (at least in this time zone) until refresh.

[Jim Bauwens]

Netham, bug fix:

Change the sql query in load.php on line 57 to

Code: (SQL) [Select]

SELECT * FROM `irc_lines`
WHERE `channel` = '%s'
OR
`type` = 'quit'
ORDER BY `line_number` DESC
LIMIT %s

I added the quit line checking. Maybe you need to do some more mods though.

[Netham45]

That'd display every quit in every channel. There's a piece of code in the bot, I can't exactly remember what function.

Though, I could make it so all quits are pulled, and check the userlist on the client and only display if that's good...

[DJ Omnimaga]

I hope you can put quit messages back, because it's kinda confusing right now X.x

[Jim Bauwens]

Netham45, here is what fixes it for me (in the bot):

Add

Code: (PHP) [Select]

$channel = str_replace(':', '', $channel);
if (!isset($userList[$channel])) $userList[$channel] = Array();
array_push($userList[$channel], $username);
to userJoin() in the bot. That should populate the userList Array, and since you made all the other functions for quit it automagickly works

I must say that the code is very very clear, so good job again!

[Netham45]

Aha, I forgot to add the users to the array on join.


Also,

Code: [Select]

if (!isset($userList[$channel])) $userList[$channel] = Array();
*should* be unnecessary. PHP should automatically treat it as an array if you give it a key. That being said, it doesn't hurt.

Edit: Fixed it. Thanks.

[Jim Bauwens]

The thing is that is didn't want to work properly without that line, so I don't know what happened there.

[Netham45]

they werent getting added to the userlist past the initial whos, so it didnt know when they quit.

[Deep Toaster]

Seems like posts from Omnom don't show up until a refresh after anyone joins/parts. Whatever I send in Omnom still shows up in IRC but Omnom doesn't get refreshed.

[Netham45]

It's working fine for me. What browser, have you cleared cache, etc...?

[DJ Omnimaga]

I see quit messages are back now. Nice work Netham45.

[Netham45]

Thank Jim too, he's the guy who pointed out my really stupid mistake. xD

[DJ Omnimaga]

Ah ok. On a side note last night I think DSP_Lord's quit showed up twice once. I do not know if it was because he's on OmniNet because the ping timeouts were the same and I do not remember OmniNet being linked back.