Omnimaga

Omnimaga => Discontinued => Our Projects => OmnomIRC Development => Topic started by: Deep Toaster on June 19, 2011, 05:44:56 pm

Title: Join/part/quit messages
Post by: Deep Toaster on June 19, 2011, 05:44:56 pm
aren't showing up anymore :(

EDIT: I lied. Join/part messages do show up, but not quits.
Title: Re: Join/part/quit messages
Post by: DJ Omnimaga on June 19, 2011, 05:49:18 pm
Yeah I noticed ???
Title: Re: Join/part/quit messages
Post by: Darl181 on June 19, 2011, 06:37:14 pm
Another bug...all joins show as [6:00:00 PM] (at least in this time zone) until refresh.
Title: Re: Join/part/quit messages
Post by: Jim Bauwens on June 20, 2011, 04:14:00 pm
Netham, bug fix:

Change the sql query in load.php on line 57 to

Code: (SQL) [Select]
SELECT * FROM `irc_lines`
WHERE `channel` = '%s'
OR
`type` = 'quit'
ORDER BY `line_number` DESC
LIMIT %s

I added the quit line checking. Maybe you need to do some more mods though.
Title: Re: Join/part/quit messages
Post by: Netham45 on June 20, 2011, 05:51:04 pm
That'd display every quit in every channel. There's a piece of code in the bot, I can't exactly remember what function.

Though, I could make it so all quits are pulled, and check the userlist on the client and only display if that's good...
Title: Re: Join/part/quit messages
Post by: DJ Omnimaga on June 21, 2011, 04:22:40 am
I hope you can put quit messages back, because it's kinda confusing right now X.x
Title: Re: Join/part/quit messages
Post by: Jim Bauwens on June 21, 2011, 04:44:04 am
Netham45, here is what fixes it for me (in the bot):

Add
Code: (PHP) [Select]
$channel = str_replace(':', '', $channel);
if (!isset($userList[$channel])) $userList[$channel] = Array();
array_push($userList[$channel], $username);
to userJoin() in the bot. That should populate the userList Array, and since you made all the other functions for quit it automagickly works :)

I must say that the code is very very clear, so good job again!
Title: Re: Join/part/quit messages
Post by: Netham45 on June 21, 2011, 05:08:12 pm
Aha, I forgot to add the users to the array on join. D:


Also,
Code: [Select]
if (!isset($userList[$channel])) $userList[$channel] = Array();
*should* be unnecessary. PHP should automatically treat it as an array if you give it a key. That being said, it doesn't hurt.

Edit: Fixed it. Thanks.
Title: Re: Join/part/quit messages
Post by: Jim Bauwens on June 21, 2011, 05:38:46 pm
The thing is that is didn't want to work properly without that line, so I don't know what happened there.
Title: Re: Join/part/quit messages
Post by: Netham45 on June 21, 2011, 06:23:47 pm
they werent getting added to the userlist past the initial whos, so it didnt know when they quit.
Title: Re: Join/part/quit messages
Post by: Deep Toaster on June 21, 2011, 09:10:06 pm
Seems like posts from Omnom don't show up until a refresh after anyone joins/parts. Whatever I send in Omnom still shows up in IRC but Omnom doesn't get refreshed.
Title: Re: Join/part/quit messages
Post by: Netham45 on June 21, 2011, 10:02:31 pm
It's working fine for me. What browser, have you cleared cache, etc...?
Title: Re: Join/part/quit messages
Post by: DJ Omnimaga on June 22, 2011, 01:00:50 am
I see quit messages are back now. Nice work Netham45.
Title: Re: Join/part/quit messages
Post by: Netham45 on June 22, 2011, 01:23:24 am
Thank Jim too, he's the guy who pointed out my really stupid mistake. xD
Title: Re: Join/part/quit messages
Post by: DJ Omnimaga on June 22, 2011, 03:08:28 pm
Ah ok. On a side note last night I think DSP_Lord's quit showed up twice once. ??? I do not know if it was because he's on OmniNet because the ping timeouts were the same and I do not remember OmniNet being linked back.
Title: Re: Join/part/quit messages
Post by: Netham45 on June 22, 2011, 04:19:31 pm
They're getting duplicated from something. I believe that the quit function isn't removing them from the array properly.
Title: Re: Join/part/quit messages
Post by: DJ Omnimaga on June 22, 2011, 04:20:40 pm
Hmm I see.

By the way your avatar is very confusing. Often I think someone else posted ???
Title: Re: Join/part/quit messages
Post by: jnesselr on June 24, 2011, 10:27:18 pm
By the way your avatar is very confusing. Often I think someone else posted ???
<offtopic>I know, that's why I think there needs to be rules on epileptic seizure causing avatars, and avatars that constantly change.</offtopic>
Title: Re: Join/part/quit messages
Post by: DJ Omnimaga on June 24, 2011, 10:41:16 pm
Lol :P
Title: Re: Join/part/quit messages
Post by: Darl181 on June 25, 2011, 02:22:23 pm
Speaking of stuff not showing up, name changes don't display for me.  Firefox 5.
Title: Re: Join/part/quit messages
Post by: calcdude84se on June 25, 2011, 02:24:24 pm
I also get this problem in Fx5.
Title: Re: Join/part/quit messages
Post by: Netham45 on June 25, 2011, 02:42:58 pm
fix'd.
Title: Re: Join/part/quit messages
Post by: Darl181 on June 27, 2011, 01:41:36 am
Not showing again.  Also the userlist is incomplete.