Calculator Community > ASM

HotkeySE | DoorsCS

<< < (3/3)

E37:
Hm. Im not really sure what you are trying to do here but Ill try to point out anything that could be a mistake.
1. I don't see Str1 declared anywhere. Since you said some of it worked I assume you declare it somewhere and just haven't shown it.
2. In you third code block, the if statement doesn't do anything unless you meant :strGet(Str1,A-1)-B to be :strGet(Str1,A-1)->B
3. In your first block of code you say :If inData(GDB1,getKey)->A I assume that you didn't actually use that code because you flipped the arguments for inData.

Nitpicky Axe coding things and optimization:
1. You use :For(G,0,8) : <Body> : End From my experience, using that type of for loop is bad practice. Unless your for loop has a variable end amount (Like you had a variable instead of the 8) using the single argument for loop is always faster, smaller and more reliable. For example :0->G:For( 8 ) : <Body> :G++:End
2. You don't need the colons on lines like "[window]"[00]:"[zoom]"[00]:"mode"[00]:"[del]"[00]:"[x^-1]"[00]:"[x^2]"[00]
3. Please put your data at the end of your code. Scrolling through a giant block of data in the middle of code isn't fun.
4. There is no real reason for GKY to be a subroutine.
5. Why are those text commands not in a loop? You could just do: 0->X:For( 8 ):Text(3,X++*2+1*3,strGet(Str1Menu,X-1)):End:[]->Str1Menu:"Edit"[00]"Lock"[00]"Arch"[00]"Cut"[00]"Copy"[00]"Paste"[00]"Rename"[00]"Folder"[00]

NonstickAtom785:
I found the issue. Thanks for the optimization tips. They were useful as heck.

Navigation

[0] Message Index

[*] Previous page

Go to full version